lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net-next 1/3] net: emaclite: Fix coding style
Date
> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Wednesday, December 18, 2019 3:27 AM
> To: Radhey Shyam Pandey <radheys@xilinx.com>
> Cc: Michal Simek <michals@xilinx.com>; netdev@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git
> <git@xilinx.com>
> Subject: Re: [PATCH net-next 1/3] net: emaclite: Fix coding style
>
> From: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Date: Mon, 16 Dec 2019 17:38:08 +0530
>
> > - spinlock_t reset_lock;
> > + spinlock_t reset_lock; /* lock used for synchronization */
>
> If you're just going to put the comment there to shut up the warnings,
> I'm not applying your patches.
>
> You have to write a thoughtful comment which explains what this lock
> actually protects.
Thanks for the review. Sure, will fix reset_lock comment
and also its kernel-doc description in v2.

\
 
 \ /
  Last update: 2019-12-18 14:36    [W:0.038 / U:9.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site