Messages in this thread |  | | From | Khouloud Touil <> | Date | Wed, 18 Dec 2019 12:10:52 +0100 | Subject | Re: [PATCH v2 1/4] dt-bindings: nvmem: new optional property write-protect-gpios |
| |
Le lun. 16 déc. 2019 à 09:08, Linus Walleij <linus.walleij@linaro.org> a écrit : > > On Tue, Dec 10, 2019 at 4:42 PM Khouloud Touil <ktouil@baylibre.com> wrote: > > > + wp-gpios: > > + description: > > + GPIO to which the write-protect pin of the chip is connected. > > + The write-protect GPIO is asserted, when it's driven high > > + (logical '1') to block the write operation. It's deasserted, > > + when it's driven low (logical '0') to allow writing. > > + maxItems: 1 > > OK I guess we can't get it less convoluted. This section is consistent. > > > patternProperties: > > "^.*@[0-9a-f]+$": > > type: object > > @@ -66,6 +74,7 @@ examples: > > qfprom: eeprom@700000 { > > #address-cells = <1>; > > #size-cells = <1>; > > + wp-gpios = <&gpio1 3 0>; > > In the example please use the include for GPIO: > > #include <dt-bindings/gpio/gpio.h> > > wp-gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>; > > You can just put the #include directive right before the > example, it should work fine.
Yes sure will fix that. Thanks for your reviews.
Best regards, Khouloud > > Yours, > Linus Walleij
|  |