Messages in this thread |  | | From | Nicolas Boichat <> | Date | Thu, 19 Dec 2019 11:51:19 +0800 | Subject | Re: [PATCH v10 05/12] soc: mediatek: Add multiple step bus protection control |
| |
On Wed, Dec 18, 2019 at 4:31 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote: > > Both MT8183 & MT6765 have more control steps of bus protection > than previous project. And there add more bus protection registers > reside at infracfg & smi-common. Also add new APIs for multiple > step bus protection control with more customized arguments. > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> ... > diff --git a/include/linux/soc/mediatek/scpsys-ext.h b/include/linux/soc/mediatek/scpsys-ext.h
Will this include file be used by anything other than drivers/soc/mediatek/scpsys*.c? If so I think you should keep it in drivers/soc/mediatek/ instead.
I also still had a comment in v9 about clr_mask, otherwise this looks ok.
|  |