lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: supply: pda_power: add missed usb_unregister_notifier
Hi,

On Fri, Nov 15, 2019 at 02:25:15PM +0800, Chuhong Yuan wrote:
> The driver forgets to unregister the notifier in remove.
> Add the call to fix it.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---

Thanks, queued to power-supply's for-next branch.

-- Sebastian

> drivers/power/supply/pda_power.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/power/supply/pda_power.c b/drivers/power/supply/pda_power.c
> index 3ae5707d39fa..03a37fd6be27 100644
> --- a/drivers/power/supply/pda_power.c
> +++ b/drivers/power/supply/pda_power.c
> @@ -429,6 +429,10 @@ static int pda_power_probe(struct platform_device *pdev)
>
> static int pda_power_remove(struct platform_device *pdev)
> {
> +#if IS_ENABLED(CONFIG_USB_PHY)
> + if (!IS_ERR_OR_NULL(transceiver) && pdata->use_otg_notifier)
> + usb_unregister_notifier(transceiver, &otg_nb);
> +#endif
> if (pdata->is_usb_online && usb_irq)
> free_irq(usb_irq->start, pda_psy_usb);
> if (pdata->is_ac_online && ac_irq)
> --
> 2.24.0
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-12-19 01:18    [W:0.030 / U:5.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site