lkml.org 
[lkml]   [2019]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings
On Wed, Dec 18, 2019 at 10:37:53AM -0800, Doug Anderson wrote:
> Hi,
>
> On Wed, Dec 18, 2019 at 4:41 AM Sandeep Maheswaram (Temp)
> <sanm@codeaurora.org> wrote:
> > + assigned-clock-rates:
> > + description:
> > + Should be 19.2MHz (19200000) for MOCK_UTMI_CLK
> > + >=125MHz (125000000) for MASTER_CLK in SS mode
> > + >=60MHz (60000000) for MASTER_CLK in HS mode
> > + maxItems: 2
> >
> > You can still express some limits here even if we don't go all out
> > with the "oneOf". AKA I think this is better:
> >
> > assigned-clock-rates:
> > items:
> > - const: 19200000
> > - minimum: 60000000
> > description: >= 60 MHz in HS mode, >= 125 MHz in SS mode
> >
> > Facing error when i add as above.
> > properties:assigned-clock-rates: {'items': [{'const': 19200000}, {'minimum': 60000000}]} is not valid under any of the given schemas
> > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/usb/qcom,dwc3.example.dts' failed

Update dtschema and you should get a better error message now.

I believe the problem is we require both minimum and maximum to be
specified or none. Maybe we should relax that, but OTOH I doubt 4GHz is
valid.

Rob

\
 
 \ /
  Last update: 2019-12-18 23:14    [W:0.053 / U:6.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site