Messages in this thread |  | | From | Doug Anderson <> | Date | Tue, 17 Dec 2019 11:22:52 -0800 | Subject | Re: [PATCH v3 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings |
| |
Hi,
On Mon, Dec 16, 2019 at 10:09 AM Stephen Boyd <swboyd@chromium.org> wrote: > > > + "#address-cells": > > + enum: [ 1, 2 ] > > + > > + "#size-cells": > > + enum: [ 1, 2 ] > > Hm... ok. Interesting.
Use of enum seems to match 'timer/arm,arch_timer_mmio.yaml'. ...and sub-device probably uses DMA so IIUC it's important to pass #size-cells of 2 down to it if the parent had it.
> > + qcom,select-utmi-as-pipe-clk: > > + description: > > Don't these multi-line descriptions need a pipe, | ?
The pipe just means that carriage returns are important. They aren't here, so I think it's OK/better w/out it. The example-schema.yaml has many without it.
> > + usb3_0: usb30@a6f8800 { > > Should node name be something like 'usb3'? Or is this usb 3.0 so it's > 'usb30'?
Probably should be just 'usb@' as per 'usb/usb-hcd.yaml'.
-Doug
|  |