lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] soc: ti: wkup_m3_ipc: Fix race condition with rproc_boot
From
Date
On 12/17/19 10:25 AM, Tony Lindgren wrote:
> Hi,
>
> * Dave Gerlach <d-gerlach@ti.com> [191211 20:02]:
>> Any user of wkup_m3_ipc calls wkup_m3_ipc_get to get a handle and this
>> checks the value of the static variable m3_ipc_state to see if the
>> wkup_m3 is ready. Currently this is populated during probe before
>> rproc_boot has been called, meaning there is a window of time that
>> wkup_m3_ipc_get can return a valid handle but the wkup_m3 itself is not
>> ready, leading to invalid IPC calls to the wkup_m3 and system
>> instability.
>>
>> To avoid this, move the population of the m3_ipc_state variable until
>> after rproc_boot has succeeded to guarantee a valid and usable handle
>> is always returned.
>
> Santosh, do you want me to pick this one into my fixes branch?
>
Sure, go ahead.

Acked-by: Santosh Shilimkar <ssantosh@kernel.org>

\
 
 \ /
  Last update: 2019-12-17 19:33    [W:0.035 / U:13.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site