lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 2/2] bluetooth: hci_bcm: enable IRQ capability from devicetree
From
Date
Hi Guillaume,

>> Actually IRQ can be found from GPIO but all platforms don't support
>> gpiod_to_irq, it's the case on amlogic chip.
>> so to have possibility to use interrupt mode we need to add interrupts
>> property in devicetree and support it in driver.
>
> I would reword this slightly (leaving out the amlogic specifics):
>
> """
> Add support for getting IRQ directly from DT instead of relying on
> converting a GPIO to IRQ. This is needed for platforms with GPIO
> controllers that that do not support gpiod_to_irq().
> """
>
> Other than that, this looks good to me and now it's clear that it only
> affects the DT path.
>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>

I reverted the broken patch and now I am waiting for v6 with proper reviewed-by or acked-by tags.

Regards

Marcel

\
 
 \ /
  Last update: 2019-12-17 08:44    [W:0.043 / U:4.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site