lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/512x: Use dma_request_chan() instead dma_request_slave_channel()
From
Date
Hi,

On 17/12/2019 9.40, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.

I sent this patch to wrong participants... Forgot to change directory.
The correct (ata: pxa:) should be on it way.

> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> index 13631f35cd14..04bf6ecf7d55 100644
> --- a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> +++ b/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
> @@ -434,9 +434,9 @@ static int mpc512x_lpbfifo_probe(struct platform_device *pdev)
> memset(&lpbfifo, 0, sizeof(struct lpbfifo_data));
> spin_lock_init(&lpbfifo.lock);
>
> - lpbfifo.chan = dma_request_slave_channel(&pdev->dev, "rx-tx");
> - if (lpbfifo.chan == NULL)
> - return -EPROBE_DEFER;
> + lpbfifo.chan = dma_request_chan(&pdev->dev, "rx-tx");
> + if (IS_ERR(lpbfifo.chan))
> + return PTR_ERR(lpbfifo.chan);
>
> if (of_address_to_resource(pdev->dev.of_node, 0, &r) != 0) {
> dev_err(&pdev->dev, "bad 'reg' in 'sclpc' device tree node\n");
>

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

\
 
 \ /
  Last update: 2019-12-17 08:43    [W:0.033 / U:25.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site