[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] vfs: Don't reject unknown parameters
On Fri, Dec 13, 2019 at 10:15:03AM +0100, Miklos Szeredi wrote:

> Just need a flag in fc indicating if this option comes from the old interface:
> if (strcmp(param->key, "source") == 0)
> return -ENOPARAM;
> /* Just log an error for backwards compatibility */
> errorf(fc, "%s: Unknown parameter '%s'", fc->fs_type->name,
> param->key);
> return fc->legacy ? 0 : -ENOPARAM;

What the hell for? Just have a separate ->parse_param() instance
for "promiscuous fs, will accept bullshit options" and have such filesystems
use it explicitly. With default being not that, but rejecting unknowns.

 \ /
  Last update: 2019-12-17 18:48    [W:0.073 / U:4.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site