lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart_port unused fields
From
Date
On 12/17/19 3:52 PM, Greg Kroah-Hartman wrote:
> On Tue, Dec 17, 2019 at 03:47:34PM +0000, Dmitry Safonov wrote:
>> On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote:
>>> The samsung_tty driver was trying to abuse the struct uart_port by using
>>> two "empty" bytes for its own use. That's not ok, and was found by
>>> removing those fields from the structure.
>>>
>>> Move the variables into the port-specific structure, which is where
>>> everything else for this port already is. There is no space wasted here
>>> as there was an empty "hole" in the structure already for these bytes.
>>
>> Thanks!
>> Sorry for not noticing this myself.
>
> You wouldn't have noticed this unless you build for that platform. I
> just recently made it buildable for other ones.

Ah, I was running CONFIG_COMPILE_TEST and thought that it should trigger
anything (and fixed an issue before sending). Probably, managed not to
enable samsung driver's option.

Thanks,
Dmitry

\
 
 \ /
  Last update: 2019-12-17 16:57    [W:0.028 / U:32.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site