lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart_port unused fields
On Tue, Dec 17, 2019 at 03:47:34PM +0000, Dmitry Safonov wrote:
> On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote:
> > The samsung_tty driver was trying to abuse the struct uart_port by using
> > two "empty" bytes for its own use. That's not ok, and was found by
> > removing those fields from the structure.
> >
> > Move the variables into the port-specific structure, which is where
> > everything else for this port already is. There is no space wasted here
> > as there was an empty "hole" in the structure already for these bytes.
>
> Thanks!
> Sorry for not noticing this myself.

You wouldn't have noticed this unless you build for that platform. I
just recently made it buildable for other ones.

>
> > Cc: Kukjin Kim <kgene@kernel.org>
> > Cc: Hyunki Koo <kkoos00@naver.com>
> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com>
> > Cc: Shinbeom Choi <sbeom.choi@samsung.com>
> > Cc: Krzysztof Kozlowski <krzk@kernel.org>
> > Cc: Dmitry Safonov <dima@arista.com>
> > Cc: Jiri Slaby <jslaby@suse.com>
> > Cc: linux-serial@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> I see you already applied it to your tree, but in case it helps anything:
> Reviewed-by: Dmitry Safonov <dima@arista.com>

The review helps, thanks :)

greg k-h

\
 
 \ /
  Last update: 2019-12-17 16:52    [W:0.039 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site