[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] tty: serial: samsung_tty: do not abuse the struct uart_port unused fields
On 12/17/19 2:02 PM, Greg Kroah-Hartman wrote:
> The samsung_tty driver was trying to abuse the struct uart_port by using
> two "empty" bytes for its own use. That's not ok, and was found by
> removing those fields from the structure.
> Move the variables into the port-specific structure, which is where
> everything else for this port already is. There is no space wasted here
> as there was an empty "hole" in the structure already for these bytes.

Sorry for not noticing this myself.

> Cc: Kukjin Kim <>
> Cc: Hyunki Koo <>
> Cc: HYUN-KI KOO <>
> Cc: Shinbeom Choi <>
> Cc: Krzysztof Kozlowski <>
> Cc: Dmitry Safonov <>
> Cc: Jiri Slaby <>
> Cc:
> Cc:
> Signed-off-by: Greg Kroah-Hartman <>

I see you already applied it to your tree, but in case it helps anything:
Reviewed-by: Dmitry Safonov <>


 \ /
  Last update: 2019-12-17 16:48    [W:0.069 / U:10.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site