lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] mm/hugetlb: Defer freeing of huge pages if in non-task context
On Tue 17-12-19 09:06:31, Waiman Long wrote:
> On 12/17/19 4:31 AM, Michal Hocko wrote:
> > On Mon 16-12-19 20:25:08, Waiman Long wrote:
[...]
> >> + pr_debug("HugeTLB: free_hpage_workfn() frees %d huge page(s)\n", cnt);
> > Why do we need the debugging message here?
>
> It is there just to verify that the workfn is properly activated and
> frees the huge page. This message won't be printed by default. I can
> remove it if you guys don't really want a debug statement here.

Yes, drop it please. We are not adding debugging messages unless they
are really actionable. If this is a sign of a bug then put a WARN_ONCE or
somethin like that. But with a simple code like this it doesn't really
seem to be suitable IMHO.

Thanks!
--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2019-12-17 16:00    [W:0.045 / U:8.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site