lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] drivers: misc: Add support for nCipher HSM devices
On Tue, Dec 17, 2019 at 01:22:44PM +0000, Dave Kim wrote:
> +/**
> + * PCI device ID table. We use the driver_data field to hold an index into
> + * nfp_drvlist, so bear than in mind when editing either.
> + */
> +static struct pci_device_id nfp_pci_tbl[] = {
> + {
> + PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_21555,
> + PCI_VENDOR_ID_NCIPHER, PCI_SUBSYSTEM_ID_NFAST_REV1, 0,
> + 0, /* Ignore class */
> + 0 /* Index into nfp_drvlist */

Please use the correct PCI_DEVICE() macros, that should work here,
right?

And you are grabbing an Intel PCI device id?

> + },
> + {
> + PCI_VENDOR_ID_FREESCALE, PCI_DEVICE_ID_FREESCALE_T1022,
> + PCI_VENDOR_ID_NCIPHER, PCI_SUBSYSTEM_ID_NFAST_REV1, 0,
> + 0, /* Ignore class */
> + 1 /* Index into nfp_drvlist */

Again, PCI_DEVICE() macros please.

And kerneldoc everywhere, your commenting format for all of the code is
a bit "odd".

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-12-17 14:39    [W:0.059 / U:8.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site