lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/23] staging: qlge: Fix WARNING: Missing a blank line after declarations
On Wed, Dec 11, 2019 at 12:12:32PM -0600, Scott Schafer wrote:
> Fix WARNING: Missing a blank line after declarations for the follig
> files:
> qlge.h
> qlge_dbg.c
> qlge_main.c
> qlge_mpi.c
>
> Signed-off-by: Scott Schafer <schaferjscott@gmail.com>
> ---
> drivers/staging/qlge/qlge.h | 1 +
> drivers/staging/qlge/qlge_dbg.c | 5 +++++
> drivers/staging/qlge/qlge_main.c | 13 +++++++++++++
> drivers/staging/qlge/qlge_mpi.c | 6 ++++++
> 4 files changed, 25 insertions(+)
>
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index 4bc5d5fce9bf..89502a8300f6 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2227,6 +2227,7 @@ static inline void ql_write_db_reg_relaxed(u32 val, void __iomem *addr)
> static inline u32 ql_read_sh_reg(__le32 *addr)
> {
> u32 reg;
> +

You are adding trailing whitespace on every one of your newlines you are
adding :(

I suggest using an editor that shows this up as a bright red mark, it
makes it more obvious you are doing something wrong.

Also try running checkpatch.pl on the patches you are writing to make
sure you do not add more errors/warnings when you are trying to fix them
up.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-12-17 13:50    [W:0.137 / U:2.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site