lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: musb: Remove unnecessary check of musb->hcd in musb_handle_intr_connect()
From
Date


On 2019/12/17 17:59, Greg KH wrote:
> On Tue, Dec 17, 2019 at 05:50:23PM +0800, Jia-Ju Bai wrote:
>> In musb_handle_intr_connect(), musb->hcd should be non-null,
>> so the check of musb->hcd on line 783 could be dropped.
> Have you verified that this is always the case? How did you do that?

Ah, so sorry, I misunderstood your last message...
I have not verified it, but I thought you made sure of it from your last
message, sorry...

In my opinion, adding an if check is safer, as shown in my last patch:
"usb: musb: Fix a possible null-pointer dereference in
musb_handle_intr_connect()"

I recall that Bin Liu has applied my last patch:
https://patchwork.kernel.org/patch/11283007/

Maybe we can listen to his opinion or other people's opinions?


Best wishes,
Jia-Ju Bai

\
 
 \ /
  Last update: 2019-12-17 13:29    [W:1.150 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site