[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip: perf/urgent] perf arch: Make the default get_cpuid() return compatible error
The following commit has been merged into the perf/urgent branch of tip:

Commit-ID: 05267c7eac12627fae3f25dfd203bfdb9941f9ca
Author: Arnaldo Carvalho de Melo <>
AuthorDate: Wed, 11 Dec 2019 10:09:24 -03:00
Committer: Arnaldo Carvalho de Melo <>
CommitterDate: Wed, 11 Dec 2019 12:25:14 -03:00

perf arch: Make the default get_cpuid() return compatible error

Some of the functions calling get_cpuid() propagate back the error it
returns, and all are using errno (positive) values, make the weak
default get_cpuid() function return ENOSYS to be consistent and to allow
checking if this is an arch not providing this function or if a provided
one is having trouble getting the cpuid, to decide if the warning should
be provided to the user or just a debug message should be emitted.

Reviewed-by: Mark Rutland <>
Tested-by: Mark Rutland <>
Tested-by: John Garry <> # arm64
Acked-by: Jiri Olsa <>
Cc: Adrian Hunter <>
Cc: Namhyung Kim <>
Cc: Will Deacon <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/util/header.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index becc2d1..4d39a75 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -850,7 +850,7 @@ int __weak strcmp_cpuid_str(const char *mapcpuid, const char *cpuid)
int __weak get_cpuid(char *buffer __maybe_unused, size_t sz __maybe_unused)
- return -1;
+ return ENOSYS; /* Not implemented */

static int write_cpuid(struct feat_fd *ff,
 \ /
  Last update: 2019-12-17 12:32    [W:0.028 / U:6.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site