lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] tty: new helper function tty_kopen_shared
On Tue, Dec 17, 2019 at 11:51:01AM +0100, Uwe Kleine-König wrote:
> Hello Greg,
>
> all feedback I don't respond to is planned to be fixed in v3.
>
> On Tue, Dec 17, 2019 at 09:27:33AM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2019 at 09:17:16AM +0100, Uwe Kleine-König wrote:
> > > +struct tty_struct *tty_kopen_shared(dev_t device)
> > > +{
> > > + struct tty_struct *tty;
> > > + struct tty_driver *driver;
> > > + int index = -1;
> > > +
> > > + mutex_lock(&tty_mutex);
> > > + driver = tty_lookup_driver(device, NULL, &index);
> > > + if (IS_ERR(driver)) {
> > > + tty = ERR_CAST(driver);
> > > + goto err_lookup_driver;
> > > + }
> > > +
> > > + tty = tty_driver_lookup_tty(driver, NULL, index);
> >
> > No error check?
>
> Well, the caller of tty_kopen_shared is supposed to check for error
> returns. Do you think an error message here would be approriate? I'd do
> this in the caller similar to how tty_kopen works.

Ah, you are passing it on to the caller, ok, nevermind.

greg k-h

\
 
 \ /
  Last update: 2019-12-17 12:06    [W:0.033 / U:5.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site