lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML
From
Date

On 12/16/2019 10:12 PM, Stephen Boyd wrote:
> Quoting Akash Asthana (2019-12-16 01:25:51)
>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> new file mode 100644
>> index 0000000..2c3b911
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
>> @@ -0,0 +1,196 @@
> [...]
>> +
>> + "serial@[0-9]+$":
>> + type: object
>> + description: GENI Serial Engine based UART Controller.
>> +
>> + properties:
>> + compatible:
>> + enum:
>> + - qcom,geni-uart
>> + - qcom,geni-debug-uart
>> +
>> + reg:
>> + description: GENI Serial Engine register address and length.
>> +
>> + interrupts:
>> + description: Contains UART core and wakeup interrupts for wakeup
>> + capable UART devices. We configure wakeup interrupt
>> + on UART RX line using TLMM interrupt controller.
>> + maxItems: 2
> Shouldn't there be a minItems: 1 here? And then you should specify the order?
> Presumably something like
>
> interrupts:
> minItems: 1
> maxItems: 2
> items:
> - description: UART core irq
> - description: Wakeup irq (RX GPIO)

Yeah ok, Thanks for correction.

I will update this in next version.

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2019-12-17 10:51    [W:0.045 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site