lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 09/15] regulator: bd71828: Basic support for ROHM bd71828 PMIC regulators
Date
Hello Mark,

On Mon, 2019-12-16 at 14:55 +0000, Mark Brown wrote:
> On Wed, Dec 11, 2019 at 11:46:11AM +0200, Matti Vaittinen wrote:
>
> > +static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev)
> > +{
> > + return BD71828_LDO_6_VOLTAGE;
> > +}
> > +
> > +static const struct regulator_ops bd71828_ldo6_ops = {
> > + .enable = regulator_enable_regmap,
> > + .disable = regulator_disable_regmap,
> > + .get_voltage = bd71828_ldo6_get_voltage,
>
> You can just set fixed_uV in the regulator_desc, you don't need a
> get_voltage() operation here. Otherwise this looks good, I'll apply
> it
> and please send an incremental fix for this.

Just to confirm - are you also taking in the
[PATCH v6 08/15] regulator: bd718x7: Split driver to common and bd718x7
specific parts

I think there is a dependency. (I am preparing next version of the
series so I'll drop the already applied patches.)

Br,
Matti Vaittinen
\
 
 \ /
  Last update: 2019-12-17 10:16    [W:0.071 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site