[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] powerpc/pseries/cmm: fix managed page counts when migrating pages between zones
On Mon, 2019-12-16 at 10:30:58 UTC, David Hildenbrand wrote:
> Commit 63341ab03706 (virtio-balloon: fix managed page counts when migrati=
> ng
> pages between zones) fixed a long existing BUG in the virtio-balloon
> driver when pages would get migrated between zones. I did not try to
> reproduce on powerpc, but looking at the code, the same should apply to
> powerpc/cmm ever since it started using the balloon compaction
> infrastructure (luckily just recently).
> In case we have to migrate a ballon page to a newpage of another zone, th=
> e
> managed page count of both zones is wrong. Paired with memory offlining
> (which will adjust the managed page count), we can trigger kernel crashes
> and all kinds of different symptoms.
> Fix it by properly adjusting the managed page count when migrating if
> the zone changed.
> We'll temporarily modify the totalram page count. If this ever becomes a
> problem, we can fine tune by providing helpers that don't touch
> the totalram pages (e.g., adjust_zone_managed_page_count()).
> Fixes: fe030c9b85e6 ("powerpc/pseries/cmm: Implement balloon compaction")
> Cc: Benjamin Herrenschmidt <>
> Cc: Paul Mackerras <>
> Cc: Michael Ellerman <>
> Cc: Andrew Morton <>
> Cc: Richard Fontana <>
> Cc: Greg Kroah-Hartman <>
> Cc: Arun KS <>
> Cc: Thomas Gleixner <>
> Cc:
> Signed-off-by: David Hildenbrand <>

Applied to powerpc fixes, thanks.


 \ /
  Last update: 2019-12-18 05:06    [W:0.025 / U:29.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site