lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] vfs: Adjust indentation in remap_verify_area
Date
Clang warns:

../fs/read_write.c:1760:3: warning: misleading indentation; statement is
not part of the previous 'if' [-Wmisleading-indentation]
if (unlikely((loff_t) (pos + len) < 0))
^
../fs/read_write.c:1757:2: note: previous statement is here
if (unlikely(pos < 0 || len < 0))
^
1 warning generated.

This warning occurs because there is a space after the tab on this line.
Remove it so that the indentation is consistent with the Linux kernel
coding style and clang no longer warns.

Fixes: 04b38d601239 ("vfs: pull btrfs clone API to vfs layer")
Link: https://github.com/ClangBuiltLinux/linux/issues/828
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
fs/read_write.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/read_write.c b/fs/read_write.c
index 5bbf587f5bc1..c71e863163bd 100644
--- a/fs/read_write.c
+++ b/fs/read_write.c
@@ -1757,7 +1757,7 @@ static int remap_verify_area(struct file *file, loff_t pos, loff_t len,
if (unlikely(pos < 0 || len < 0))
return -EINVAL;

- if (unlikely((loff_t) (pos + len) < 0))
+ if (unlikely((loff_t) (pos + len) < 0))
return -EINVAL;

if (unlikely(inode->i_flctx && mandatory_lock(inode))) {
--
2.24.1
\
 
 \ /
  Last update: 2019-12-18 04:24    [W:0.039 / U:1.724 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site