[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next 4/8] net: bcmgenet: Refactor bcmgenet_set_features()
On 12/17/19 1:02 PM, Doug Berger wrote:
> In preparation for unconditionally enabling TX and RX checksum
> offloads, refactor bcmgenet_set_features() a bit such that
> __netdev_update_features() during register_netdev() can make sure
> that features are correctly programmed during network device
> registration.
> Since we can now be called during register_netdev() with clocks
> gated, we need to temporarily turn them on/off in order to have a
> successful register programming.
> We also move the CRC forward setting read into
> bcmgenet_set_features() since priv->crc_fwd_en matters while
> turning on RX checksum offload, that way we are guaranteed they
> are in sync in case we ever add support for NETIF_F_RXFCS at some
> point in the future.
> Signed-off-by: Doug Berger <>

Reviewed-by: Florian Fainelli <>

 \ /
  Last update: 2019-12-18 00:03    [W:0.140 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site