Messages in this thread |  | | Date | Tue, 17 Dec 2019 08:05:09 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v2 4/5] drm/i915/dsi: Move Crystal Cove PMIC panel GPIO lookup from mfd to the i915 driver |
| |
On Mon, 16 Dec 2019, Hans de Goede wrote:
> Move the Crystal Cove PMIC panel GPIO lookup-table from > drivers/mfd/intel_soc_pmic_core.c to the i915 driver. > > The moved looked-up table is adding a GPIO lookup to the i915 PCI > device and the GPIO subsys allows only one lookup table per device, > > The intel_soc_pmic_core.c code only adds lookup-table entries for the > PMIC panel GPIO (as it deals only with the PMIC), but we also need to be > able to access some GPIOs on the SoC itself, which requires entries for > these GPIOs in the lookup-table. > > Since the lookup-table is attached to the i915 PCI device it really > should be part of the i915 driver, this will also allow us to extend > it with GPIOs from other sources when necessary. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> > Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 23 +++++++++++++++++++- > drivers/mfd/intel_soc_pmic_core.c | 19 ---------------- > 2 files changed, 22 insertions(+), 20 deletions(-)
Acked-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
|  |