[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] hdlcdrv: replace unnecessary assertion in hdlcdrv_register
> The three callers of hdlcdrv_register all pass valid pointers and
> do not fail. The patch eliminates the unnecessary BUG_ON assertion.

I suggest to replace the wording “The patch eliminates” by “Thus delete”
to make it imperative as desired.

Will the tag “Fixes” be added to the final change description?

> ---
> drivers/net/hamradio/hdlcdrv.c | 2 --

Please replace these triple dashes by a blank line.


 \ /
  Last update: 2019-12-17 22:27    [W:0.033 / U:25.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site