lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [staging-next] isdn: don't mark kcapi_proc_exit as __exit
On Mon, Dec 16, 2019 at 08:48:56PM +0100, Arnd Bergmann wrote:
> As everybody pointed out by now, my patch to clean up CAPI introduced
> a link time warning, as the two parts of the capi driver are now in
> one module and the exit function may need to be called in the error
> path of the init function:
>
> >> WARNING: drivers/isdn/capi/kernelcapi.o(.text+0xea4): Section mismatch in reference from the function kcapi_exit() to the function .exit.text:kcapi_proc_exit()
> The function kcapi_exit() references a function in an exit section.
> Often the function kcapi_proc_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of kcapi_proc_exit.
>
> Remove the incorrect __exit annotation.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Reported-by: Olof's autobuilder <build@lixom.net>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/isdn/capi/kcapi_proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for this, now applied.

greg k-h

\
 
 \ /
  Last update: 2019-12-17 09:01    [W:0.030 / U:7.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site