lkml.org 
[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 03/19] KVM: Don't free new memslot if allocation of said memslot fails
    Date
    The two implementations of kvm_arch_create_memslot() in x86 and PPC are
    both good citizens and free up all local resources if creation fails.
    Return immediately (via a superfluous goto) instead of calling
    kvm_free_memslot().

    Note, the call to kvm_free_memslot() is effectively an expensive nop in
    this case as there are no resources to be freed.

    No functional change intended.

    Acked-by: Christoffer Dall <christoffer.dall@arm.com>
    Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    ---
    virt/kvm/kvm_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
    index f14bde936c09..7239e3b9dda0 100644
    --- a/virt/kvm/kvm_main.c
    +++ b/virt/kvm/kvm_main.c
    @@ -1092,7 +1092,7 @@ int __kvm_set_memory_region(struct kvm *kvm,
    new.userspace_addr = mem->userspace_addr;

    if (kvm_arch_create_memslot(kvm, &new, npages))
    - goto out_free;
    + goto out;
    }

    /* Allocate page dirty bitmap if needed */
    --
    2.24.1
    \
     
     \ /
      Last update: 2019-12-17 21:43    [W:2.710 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site