[lkml]   [2019]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers
Hi Lee,

On 12/17/19 2:46 PM, Lee Jones wrote:
> One thing I should mention upfront; there is too much code "doing
> things" in here for it to be an MFD. MFDs don't care about; syncs,
> slots, TDM, inverting lines, upstreams, downstreams, etc etc etc.
> Anything remotely technical or functional, the code that "does things"
> should be moved out to the relevant areas. In the case of this
> device, that's looking like one of the Audio related subsystems.

Okay, that's good to know.

I in fact considered that when I started working on it; after all, A2B
stands for "automotive audio bus". The reason why I didn't do it was the
fact that these devices certainly do have multiple functions, where
audio is just one of them, and there needs to be a 'top-level' layer
that enables all these functions and does the node discovery etc. Hence
I thought it's cleaner to separate things that way.

I can move things over to the ASoC layer for the next iteration, and
then maybe also merge the codec driver with the baseline drivers. Let's
see how this looks like then.


 \ /
  Last update: 2019-12-17 20:37    [W:0.046 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site