lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] reiserfs: prevent NULL pointer dereference in reiserfs_insert_item()
On Mon 16-12-19 20:05:32, Yunfeng Ye wrote:
> The variable inode may be NULL in reiserfs_insert_item(), but there is
> no check before accessing the member of inode.
>
> Fix this by adding NULL pointer check before calling reiserfs_debug().
>
> Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>

Thanks, I've added the patch to my tree.

Honza

> ---
> fs/reiserfs/stree.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index da9ebe33882b..bb4973aefbb1 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -2246,7 +2246,8 @@ int reiserfs_insert_item(struct reiserfs_transaction_handle *th,
> /* also releases the path */
> unfix_nodes(&s_ins_balance);
> #ifdef REISERQUOTA_DEBUG
> - reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE,
> + if (inode)
> + reiserfs_debug(th->t_super, REISERFS_DEBUG_CODE,
> "reiserquota insert_item(): freeing %u id=%u type=%c",
> quota_bytes, inode->i_uid, head2type(ih));
> #endif
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR

\
 
 \ /
  Last update: 2019-12-16 18:06    [W:0.047 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site