Messages in this thread |  | | From | Frank Lee <> | Date | Mon, 16 Dec 2019 23:27:44 +0800 | Subject | Re: [PATCH 1/3] clocksource: em_sti: convert to devm_platform_ioremap_resource |
| |
On Mon, Dec 16, 2019 at 9:44 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On 15/12/2019 16:17, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > Even if the change is obvious, elaborate a bit the changelog. > > > BTW, do another small cleanup. > > Keep one change per patch.
OK... My fault.
Any comments on the other two?
MBR, Yangtao
> > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > > --- > > drivers/clocksource/em_sti.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c > > index 9039df4f90e2..ab190dffb1ed 100644 > > --- a/drivers/clocksource/em_sti.c > > +++ b/drivers/clocksource/em_sti.c > > @@ -279,9 +279,7 @@ static void em_sti_register_clockevent(struct em_sti_priv *p) > > static int em_sti_probe(struct platform_device *pdev) > > { > > struct em_sti_priv *p; > > - struct resource *res; > > - int irq; > > - int ret; > > + int irq, ret; > > > > p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL); > > if (p == NULL) > > @@ -295,8 +293,7 @@ static int em_sti_probe(struct platform_device *pdev) > > return irq; > > > > /* map memory, let base point to the STI instance */ > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - p->base = devm_ioremap_resource(&pdev->dev, res); > > + p->base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(p->base)) > > return PTR_ERR(p->base); > > > > > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog >
|  |