Messages in this thread |  | | From | Nicolas Boichat <> | Date | Mon, 16 Dec 2019 15:42:34 +0800 | Subject | Re: [PATCH v9 7/9] soc: mediatek: Add MT8183 scpsys support |
| |
Just a minor nit, but I can't really comment on the exact register addresses (what I could find in register table made sense).
On Tue, Dec 10, 2019 at 2:47 PM Weiyi Lu <weiyi.lu@mediatek.com> wrote: > > Add scpsys driver for MT8183 > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com>
Otherwise:
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> --- > drivers/soc/mediatek/mtk-scpsys.c | 226 ++++++++++++++++++++++++++++++++++++++ > [snip] > @@ -1197,6 +1409,17 @@ static void mtk_register_power_domains(struct platform_device *pdev, > .bus_prot_reg_update = true, > }; > > +static const struct scp_soc_data mt8183_data = { > + .domains = scp_domain_data_mt8183, > + .num_domains = ARRAY_SIZE(scp_domain_data_mt8183), > + .subdomains = scp_subdomain_mt8183, > + .num_subdomains = ARRAY_SIZE(scp_subdomain_mt8183), > + .regs = { > + .pwr_sta_offs = 0x0180, > + .pwr_sta2nd_offs = 0x0184
Add a comma at the end.
> + } > +}; > + > /* > * scpsys driver init > */ > @@ -1221,6 +1444,9 @@ static void mtk_register_power_domains(struct platform_device *pdev, > .compatible = "mediatek,mt8173-scpsys", > .data = &mt8173_data, > }, { > + .compatible = "mediatek,mt8183-scpsys", > + .data = &mt8183_data, > + }, { > /* sentinel */ > } > }; > -- > 1.8.1.1.dirty
|  |