Messages in this thread |  | | From | Geert Uytterhoeven <> | Date | Mon, 16 Dec 2019 14:31:15 +0100 | Subject | Re: [PATCH 1/1] Fix undefined reference to 'node_reclaim_distance'. |
| |
Hi Gon,
On Mon, Dec 16, 2019 at 2:21 PM Gonsolo <gonsolo@gmail.com> wrote: > > Unfortunately that may be an x86-centric assumption: on other platforms, > > there do exist systems with multiple memory banks with different access > > performance figures. > > Does that mean that the line > > obj-$(CONFIG_SMP) += cpupri.o cpudeadline.o topology.o stop_task.o pelt.o > > in kernel/sched/topology/Makefile:23 is wrong? > > Because in topology.c:1284 the variable node_reclaim_distance ist defined > which is used in mm/page_alloc.c:3529 without depending on SMP.
The offending commit seems to be a55c7454a8c887b2 ("sched/topology: Improve load balancing on AMD EPYC systems").
Probably the node_reclaim_distance variable should be moved from an SMP-specific file to a NUMA-specific file.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|  |