Messages in this thread |  | | Subject | Re: [PATCH v5 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog | From | Guenter Roeck <> | Date | Mon, 16 Dec 2019 05:30:08 -0800 |
| |
On 12/15/19 10:03 PM, Xingyu Chen wrote: > Hi, Martin > > Sorry for the late reply. > > On 2019/12/13 4:05, Martin Blumenstingl wrote: >> Hi Xingyu and Rob, >> >> On Thu, Dec 12, 2019 at 1:20 PM Xingyu Chen <xingyu.chen@amlogic.com> wrote: >> [...] >>> +examples: >>> + - | >>> + watchdog { >>> + compatible = "amlogic,meson-sec-wdt"; >>> + timeout-sec = <60>; >>> + }; >> in v3 of this patch Rob commented that there shouldn't be an OF node >> if there are no additional properties >> with timeout-sec there's now an additional property so my >> understanding is that it's fine to have an OF node > Your understanding is correct. >> >> what I don't understand yet is where this node should be placed. >> is it supposed to be a child node of the secure monitor node (for >> which we already have a binding here: >> Documentation/devicetree/bindings/firmware/meson/meson_sm.txt) or >> where else would we place it inside the .dts? > IMO, Although the watchdog node need to reference the meson_sm node, there is no > bus-like dependencies between the devices which the two nodes corresponding to. > so i think that the watchdog node as child node of meson_sm maybe not appropriate.
The watchdog driver needs the meson SM's dt node, and it depends on the existence of that node. That seems enough of a relationship to warrant having it as child note.
Guenter
|  |