lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] EDAC: remove set but not used variable 'ecc_loc'
Em Mon, 16 Dec 2019 19:01:21 +0800
yu kuai <yukuai3@huawei.com> escreveu:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
> drivers/edac/i5100_edac.c:489:11: warning: variable ‘ecc_loc’
> set but not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed.
> Signed-off-by: yu kuai <yukuai3@huawei.com>
> ---
> changes in V2
> -remove the definition of the function i5100_redmemb_ecc_locator()

Sounds ok on my eyes.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> drivers/edac/i5100_edac.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/edac/i5100_edac.c b/drivers/edac/i5100_edac.c
> index 0ddc41e47a96..191aa7c19ded 100644
> --- a/drivers/edac/i5100_edac.c
> +++ b/drivers/edac/i5100_edac.c
> @@ -259,11 +259,6 @@ static inline u32 i5100_nrecmemb_ras(u32 a)
> return a & ((1 << 16) - 1);
> }
>
> -static inline u32 i5100_redmemb_ecc_locator(u32 a)
> -{
> - return a & ((1 << 18) - 1);
> -}
> -
> static inline u32 i5100_recmema_merr(u32 a)
> {
> return i5100_nrecmema_merr(a);
> @@ -486,7 +481,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
> u32 dw;
> u32 dw2;
> unsigned syndrome = 0;
> - unsigned ecc_loc = 0;
> unsigned merr;
> unsigned bank;
> unsigned rank;
> @@ -499,7 +493,6 @@ static void i5100_read_log(struct mem_ctl_info *mci, int chan,
> pci_read_config_dword(pdev, I5100_REDMEMA, &dw2);
> syndrome = dw2;
> pci_read_config_dword(pdev, I5100_REDMEMB, &dw2);
> - ecc_loc = i5100_redmemb_ecc_locator(dw2);
> }
>
> if (i5100_validlog_recmemvalid(dw)) {




Cheers,
Mauro

\
 
 \ /
  Last update: 2019-12-16 13:02    [W:0.095 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site