lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 01/10] PCMCIA/i82092: use dev_<level> instead of printk
On Fri, Dec 13, 2019 at 02:53:04PM +0100, Simon Geis wrote:
> Improve the log output by using the
> device-aware dev_err()/dev_info() functions. While at it, update one
> remaining printk(KERN_ERR ...) call to the preferred pr_err() call
> and delete commented out debugging lines.
>
> Co-developed-by: Lukas Panzer <lukas.panzer@fau.de>
> Signed-off-by: Lukas Panzer <lukas.panzer@fau.de>
> Signed-off-by: Simon Geis <simon.geis@fau.de>

Applied, minus the one hunk which didn't serve any purpose:

> @@ -417,7 +421,9 @@ static int i82092aa_init(struct pcmcia_socket *sock)
>
> static int i82092aa_get_status(struct pcmcia_socket *socket, u_int *value)
> {
> - unsigned int sock = container_of(socket, struct socket_info, socket)->number;
> + struct socket_info *sock_info = container_of(socket, struct socket_info,
> + socket);
> + unsigned int sock = sock_info->number;
> unsigned int status;
>
> enter("i82092aa_get_status");

Thanks,
Dominik

\
 
 \ /
  Last update: 2019-12-16 12:24    [W:0.064 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site