Messages in this thread |  | | Subject | Re: [PATCH 0/5] drm/i915/dsi: Control panel and backlight enable GPIOs from VBT | From | Hans de Goede <> | Date | Mon, 16 Dec 2019 12:11:31 +0100 |
| |
Hi,
On 16-12-2019 11:26, Linus Walleij wrote: > On Sun, Dec 15, 2019 at 5:38 PM Hans de Goede <hdegoede@redhat.com> wrote: > >> Linus, this series starts with the already discussed pinctrl change to >> export the function to unregister a pinctrl-map. We can either merge this >> through drm-intel, or you could pick it up and then provide an immutable >> branch with it for merging into drm-intel-next. Which option do you prefer? > > I have created an immutable branch with these changes and pulled it > to my "devel" branch for v5.6: > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-unreg-mappings
Ugh, taking one last look at the "pinctrl: Export pinctrl_unregister_mappings" patch it is no good, sorry.
I just realized that if the mapping has been dupped, the if (maps_node->maps == map) check will never be true, because maps_node->maps is the return value from kmemdup and map is the map originally passed in while registering.
Linus, can you please drop this from your -next ?
So I see 2 options: 1) Add an orig_map member to maps_node and use that in the comparison, this is IMHO somewhat ugly
2) Add a new pinctrl_register_mappings_no_dup helper and document in pinctrl_unregister_mappings kdoc that it can only be used together with the no_dup variant.
I believe that 2 is by far the best option. Linus do you agree or do you have any other suggestions?
Regards,
Hans
|  |