Messages in this thread |  | | Date | Mon, 16 Dec 2019 10:54:52 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: madera: Improve handling of regulator unbinding |
| |
On Mon, 09 Dec 2019, Charles Keepax wrote:
> The current unbinding process for Madera has some issues. The trouble > is runtime PM is disabled as the first step of the process, but > some of the drivers release IRQs causing regmap IRQ to issue a > runtime get which fails. To allow runtime PM to remain enabled during > mfd_remove_devices, the DCVDD regulator must remain available. In > the case of external DCVDD's this is simple, the regulator can simply > be disabled/put after the call to mfd_remove_devices. However, in > the case of an internally supplied DCVDD the regulator needs to be > released after all the MFD children, except for the regulator child > itself, have been removed. This is achieved by having the regulator > driver itself do the disable/put, as it is the last driver removed from > the MFD. > > Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> > --- > drivers/mfd/madera-core.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-)
I'm okay with it if Mark is:
For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
|  |