Messages in this thread |  | | Subject | Re: [PATCH =v2 1/3] tpm: fix invalid locking in NONBLOCKING mode | From | Jarkko Sakkinen <> | Date | Tue, 17 Dec 2019 03:32:33 +0200 |
| |
On Thu, 2019-12-12 at 09:48 -0800, Tadeusz Struk wrote: > When an application sends TPM commands in NONBLOCKING mode > the driver holds chip->tpm_mutex returning from write(), > which triggers: "WARNING: lock held when returning to user space". > To fix this issue the driver needs to release the mutex before > returning and acquire it again in tpm_dev_async_work() before > sending the command.
This is way better, thank you. I'll put this to my rc3 PR.
> > Cc: stable@vger.kernel.org > Fixes: 9e1b74a63f776 (tpm: add support for nonblocking operation) > Reported-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in> > Tested-by: Jeffrin Jose T <jeffrin@rajagiritech.edu.in> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
|  |