lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 02/10] mm/lru: replace pgdat lru_lock with lruvec lock
From
Date


在 2019/12/16 下午8:14, Matthew Wilcox 写道:
> On Mon, Dec 16, 2019 at 05:26:18PM +0800, Alex Shi wrote:
>> -static void lock_page_lru(struct page *page, int *isolated)
>> +static struct lruvec *lock_page_lru(struct page *page, int *isolated)
>> {
>> - pg_data_t *pgdat = page_pgdat(page);
>> + struct lruvec *lruvec = lock_page_lruvec_irq(page);
>>
>> - spin_lock_irq(&pgdat->lru_lock);
>> if (PageLRU(page)) {
>> - struct lruvec *lruvec;
>>
>> - lruvec = mem_cgroup_page_lruvec(page, pgdat);
>> ClearPageLRU(page);
>> del_page_from_lru_list(page, lruvec, page_lru(page));
>> *isolated = 1;
>> } else
>> *isolated = 0;
>> +
>> + return lruvec;
>> }
>
> You still didn't fix this function. Go back and look at my comment from
> the last time you sent this patch set.
>

Sorry for the misunderstanding. I guess what your want is fold the patch 9th into this, is that right?
Any comments for the 9th patch?

Thanks
Alex

\
 
 \ /
  Last update: 2019-12-17 02:30    [W:0.045 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site