Messages in this thread Patch in this message |  | | Date | Tue, 17 Dec 2019 08:46:00 +0800 | From | cang@codeauro ... | Subject | Re: [PATCH 1/2] scsi: ufs: Put SCSI host after remove it |
| |
On 2019-12-17 01:39, Bart Van Assche wrote: > On 12/16/19 6:31 AM, cang@codeaurora.org wrote: >> As SCSI host is allocated in ufshcd_platform_init() during platform >> drive probe, it is much more appropriate if platform driver calls >> ufshcd_dealloc_host() in their own drv->remove() path. How do you >> think if I change it as below? If it is OK to you, please ignore my >> previous mails. >> >> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c >> index 3d4582e..ea45756 100644 >> --- a/drivers/scsi/ufs/ufs-qcom.c >> +++ b/drivers/scsi/ufs/ufs-qcom.c >> @@ -3239,6 +3239,7 @@ static int ufs_qcom_remove(struct >> platform_device *pdev) >> >> pm_runtime_get_sync(&(pdev)->dev); >> ufshcd_remove(hba); >> + ufshcd_dealloc_host(hba); >> return 0; >> } > > Hi Can, > > Apparently some UFS drivers call ufshcd_remove() only and others > (PCIe) call both ufshcd_remove() and ufshcd_dealloc_host(). I think > that the above change will cause trouble for the PCIe driver unless > the ufshcd_dealloc_host() call is removed from ufshcd_pci_remove(). > > Thanks, > > Bart.
Hi Bart,
You may get me wrong. I mean we should do like what ufshcd-pci.c does. As driver probe routine allocates SCSI host, then driver remove() should de-allocate it. Meaning ufs_qcom_remove() should call both ufshcd_remove() and ufshcd_dealloc_host().
diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c index 3d4582e..ea45756 100644 --- a/drivers/scsi/ufs/ufs-qcom.c +++ b/drivers/scsi/ufs/ufs-qcom.c @@ -3239,6 +3239,7 @@ static int ufs_qcom_remove(struct platform_device *pdev)
pm_runtime_get_sync(&(pdev)->dev); ufshcd_remove(hba); + ufshcd_dealloc_host(hba); return 0; } Thanks,
Can Guo.
|  |