lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/2] IMA: Define workqueue for early boot "key" measurements
From
Date
On 12/16/2019 4:30 AM, Mimi Zohar wrote:

>> +
>> + if (!list_empty(&ima_keys)) {
>> + list_for_each_entry_safe(entry, tmp, &ima_keys, list)
>> + list_move_tail(&entry->list, &temp_ima_keys);
>> + process = true;
>> + }
>> + }
>> +
>> + mutex_unlock(&ima_keys_mutex);
>> +
>> + if (!process)
>> + return;
>
> The new changes - checking if the list is empty and this test - are
> unnecessary, as you implied earlier.
>
> Mimi

Do you want me to remove this check? I feel it is safer to have this
check - use a local flag "process" to return if no keys were moved to
the temp list. Would like to leave it as is - if you don't mind.

thanks,
-lakshmi


\
 
 \ /
  Last update: 2019-12-17 00:45    [W:0.045 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site