lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] spi: bcm2835: no dev_err() on clk_get() -EPROBE_DEFER
From
Date
On 12/16/19 3:08 PM, Jim Quinlan wrote:
> Use dev_dbg() on -EPROBE_DEFER and dev_err() on all
> other errors.
>
> Signed-off-by: Jim Quinlan <jquinlan@broadcom.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

> ---
> drivers/spi/spi-bcm2835.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm2835.c b/drivers/spi/spi-bcm2835.c
> index fb61a620effc..e4b57b751ce2 100644
> --- a/drivers/spi/spi-bcm2835.c
> +++ b/drivers/spi/spi-bcm2835.c
> @@ -1305,7 +1305,10 @@ static int bcm2835_spi_probe(struct platform_device *pdev)
> bs->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(bs->clk)) {
> err = PTR_ERR(bs->clk);
> - dev_err(&pdev->dev, "could not get clk: %d\n", err);
> + if (err == -EPROBE_DEFER)
> + dev_dbg(&pdev->dev, "could not get clk: %d\n", err);
> + else
> + dev_err(&pdev->dev, "could not get clk: %d\n", err);
> goto out_controller_put;
> }
>
>


--
Florian

\
 
 \ /
  Last update: 2019-12-17 00:11    [W:0.047 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site