Messages in this thread |  | | Subject | Re: [PATCH v4 1/6] arm/arm64/xen: hypercall.h add includes guards | From | Julien Grall <> | Date | Mon, 16 Dec 2019 20:36:23 +0000 |
| |
Hi,
On 04/12/2019 23:20, Pavel Tatashin wrote: > The arm and arm64 versions of hypercall.h are missing the include > guards. This is needed because C inlines for privcmd_call are going to > be added to the files. > > Also fix a comment. > > Signed-off-by: Pavel Tatashin <pasha.tatashin@soleen.com> > --- > arch/arm/include/asm/assembler.h | 2 +- > arch/arm/include/asm/xen/hypercall.h | 4 ++++ > arch/arm64/include/asm/xen/hypercall.h | 4 ++++ > include/xen/arm/hypercall.h | 6 +++--- > 4 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/include/asm/assembler.h b/arch/arm/include/asm/assembler.h > index 99929122dad7..8e9262a0f016 100644 > --- a/arch/arm/include/asm/assembler.h > +++ b/arch/arm/include/asm/assembler.h > @@ -480,7 +480,7 @@ THUMB( orr \reg , \reg , #PSR_T_BIT ) > .macro uaccess_disable, tmp, isb=1 > #ifdef CONFIG_CPU_SW_DOMAIN_PAN > /* > - * Whenever we re-enter userspace, the domains should always be > + * Whenever we re-enter kernel, the domains should always be
This feels unrelated from the rest of the patch and probably want an explanation. So I think this want to be in a separate patch.
The rest of the patch looks good to me.
Cheers,
-- Julien Grall
|  |