Messages in this thread |  | | From | Arnd Bergmann <> | Date | Mon, 16 Dec 2019 10:31:53 +0100 | Subject | Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency |
| |
On Mon, Dec 16, 2019 at 9:42 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > We recently fixed a compile error by adding > depends on OF > and I think OF implies HAS_IOMEM so this should be fixed > now. > > Can you confirm?
I'm fairly sure it does not, so both patches are needed.
Arnd
|  |