Messages in this thread Patch in this message |  | | From | Trond Myklebust <> | Subject | Re: [PATCH] NFSv4: open() should try lease recovery on NFS4ERR_EXPIRED | Date | Mon, 16 Dec 2019 18:39:54 +0000 |
| |
On Mon, 2019-12-16 at 17:54 +0000, Robert Milkowski wrote: > From: Robert Milkowski <rmilkowski@gmail.com> > > Currently, if an nfs server returns NFS4ERR_EXPIRED to open, > we return EIO to applications without even trying to recover. > > Signed-off-by: Robert Milkowski <rmilkowski@gmail.com> > --- > fs/nfs/nfs4proc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c > index aad65dd..04e6a13 100644 > --- a/fs/nfs/nfs4proc.c > +++ b/fs/nfs/nfs4proc.c > @@ -481,6 +481,10 @@ static int nfs4_do_handle_exception(struct > nfs_server > *server, > stateid); > goto wait_on_recovery; > } > + if (state == NULL) { > + nfs4_schedule_lease_recovery(clp); > + goto wait_on_recovery; > + } > /* Fall through */ > case -NFS4ERR_OPENMODE: > if (inode) {
Ugh. If we need a state==NULL for NFSv4.0, then let's get rid of the switch() fall through in the above case, and rather add a delegation return to the EXPIRED handling.
-- Trond Myklebust Linux NFS client maintainer, Hammerspace trond.myklebust@hammerspace.com
|  |