[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage
On Thu, Dec 12, 2019 at 11:03:54AM -0800, David Miller wrote:
> From: "Enrico Weigelt, metux IT consult" <>
> Date: Thu, 12 Dec 2019 14:36:13 +0100
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT consult <>
> Is there a plan to remove MODULE_VERSION across the entire kernel tree?
> Where is that documented?
> Otherwise what gave you the reason to make this change in the first place?

Dave, see this conversation which I had two years ago with positive
responses from many respectable developers.

Greg's response:
Linus's response:


> No context, no high level explanation of what's going on, so it's hard
> to review and decide whether to accept your change sorry.
> At the least, you will have to write a more complete commit log message.

 \ /
  Last update: 2019-12-16 10:05    [W:0.083 / U:6.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site