lkml.org 
[lkml]   [2019]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 135/177] pinctrl: samsung: Fix device node refcount leaks in S3C24xx wakeup controller init
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    commit 6fbbcb050802d6ea109f387e961b1dbcc3a80c96 upstream.

    In s3c24xx_eint_init() the for_each_child_of_node() loop is used with a
    break to find a matching child node. Although each iteration of
    for_each_child_of_node puts the previous node, but early exit from loop
    misses it. This leads to leak of device node.

    Cc: <stable@vger.kernel.org>
    Fixes: af99a7507469 ("pinctrl: Add pinctrl-s3c24xx driver")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/samsung/pinctrl-s3c24xx.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
    +++ b/drivers/pinctrl/samsung/pinctrl-s3c24xx.c
    @@ -490,8 +490,10 @@ static int s3c24xx_eint_init(struct sams
    return -ENODEV;

    eint_data = devm_kzalloc(dev, sizeof(*eint_data), GFP_KERNEL);
    - if (!eint_data)
    + if (!eint_data) {
    + of_node_put(eint_np);
    return -ENOMEM;
    + }

    eint_data->drvdata = d;

    @@ -503,12 +505,14 @@ static int s3c24xx_eint_init(struct sams
    irq = irq_of_parse_and_map(eint_np, i);
    if (!irq) {
    dev_err(dev, "failed to get wakeup EINT IRQ %d\n", i);
    + of_node_put(eint_np);
    return -ENXIO;
    }

    eint_data->parents[i] = irq;
    irq_set_chained_handler_and_data(irq, handlers[i], eint_data);
    }
    + of_node_put(eint_np);

    bank = d->pin_banks;
    for (i = 0; i < d->nr_banks; ++i, ++bank) {

    \
     
     \ /
      Last update: 2019-12-16 19:23    [W:5.343 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site