| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.3 006/180] scsi: qla2xxx: Fix memory leak when sending I/O fails | Date | Mon, 16 Dec 2019 18:47:26 +0100 |
| |
From: Arun Easi <aeasi@marvell.com>
commit 2f856d4e8c23f5ad5221f8da4a2f22d090627f19 upstream.
On heavy loads, a memory leak of the srb_t structure is observed. This would make the qla2xxx_srbs cache gobble up memory.
Fixes: 219d27d7147e0 ("scsi: qla2xxx: Fix race conditions in the code for aborting SCSI commands") Cc: stable@vger.kernel.org # 5.2 Link: https://lore.kernel.org/r/20191105150657.8092-7-hmadhani@marvell.com Reviewed-by: Ewan D. Milne <emilne@redhat.com> Signed-off-by: Arun Easi <aeasi@marvell.com> Signed-off-by: Himanshu Madhani <hmadhani@marvell.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/scsi/qla2xxx/qla_os.c | 4 ++++ 1 file changed, 4 insertions(+)
--- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -947,6 +947,8 @@ qla2xxx_queuecommand(struct Scsi_Host *h qc24_host_busy_free_sp: sp->free(sp); + CMD_SP(cmd) = NULL; + qla2x00_rel_sp(sp); qc24_host_busy: return SCSI_MLQUEUE_HOST_BUSY; @@ -1036,6 +1038,8 @@ qla2xxx_mqueuecommand(struct Scsi_Host * qc24_host_busy_free_sp: sp->free(sp); + CMD_SP(cmd) = NULL; + qla2xxx_rel_qpair_sp(sp->qpair, sp); qc24_host_busy: return SCSI_MLQUEUE_HOST_BUSY;
|