lkml.org 
[lkml]   [2019]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] staging: comedi: drivers: Fix memory leak in gsc_hpdi_auto_attach
From
Date
> In the implementation of gsc_hpdi_auto_attach(), the allocated dma
> description is leaks in case of alignment error, …

Please avoid a typo in this change message.



+++ b/drivers/staging/comedi/drivers/gsc_hpdi.c

> @@ -660,6 +661,15 @@ static int gsc_hpdi_auto_attach(struct comedi_device *dev,
> s->cancel = gsc_hpdi_cancel;
>
> return gsc_hpdi_init(dev);
> +
> +release_dma_desc:
> + if (devpriv->dma_desc)
> + dma_free_coherent(&pcidev->dev,
> + sizeof(struct plx_dma_desc) *
> + NUM_DMA_DESCRIPTORS,
> + devpriv->dma_desc,
> + devpriv->dma_desc_phys_addr);
> + return retval;
> }
>
> static void gsc_hpdi_detach(struct comedi_device *dev)

I got the impression that return values from calls of the function “dma_alloc_coherent”
should be checked before.
* Would you like to add null pointer checks at other source code places?
* Should the jump targets be accordingly adjusted then for the completion
of the desired exception handling?

Regards,
Markus

\
 
 \ /
  Last update: 2019-12-15 16:08    [W:2.149 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site